Skip to content

inquire version update is required #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

inquire version update is required #459

wants to merge 1 commit into from

Conversation

dev-splin
Copy link

Package updates are required because there are useful features such as description of the inquire checkbox.

@crutchcorn
Copy link
Member

This cannot be merged in as-is due to breaks in inquierer since the original version:

node-plop:test:
node-plop:test: Error: /Users/crutchcorn/git/plopjs/plop/packages/node-plop/types/index.d.ts:3:3
node-plop:test: ERROR: 3:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'CheckboxQuestion'. Did you mean to use 'import CheckboxQuestion from "inquirer"' instead?
node-plop:test: ERROR: 4:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'ConfirmQuestion'. Did you mean to use 'import ConfirmQuestion from "inquirer"' instead?
node-plop:test: ERROR: 5:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'EditorQuestion'. Did you mean to use 'import EditorQuestion from "inquirer"' instead?
node-plop:test: ERROR: 6:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'ExpandQuestion'. Did you mean to use 'import ExpandQuestion from "inquirer"' instead?
node-plop:test: ERROR: 7:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'InputQuestion'. Did you mean to use 'import InputQuestion from "inquirer"' instead?
node-plop:test: ERROR: 8:3    expect  TypeScript@local compile error:
node-plop:test: '"inquirer"' has no exported member named 'ListQuestion'. Did you mean 'Question'?
node-plop:test: ERROR: 9:3    expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'NumberQuestion'. Did you mean to use 'import NumberQuestion from "inquirer"' instead?
node-plop:test: ERROR: 10:3   expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'PasswordQuestion'. Did you mean to use 'import PasswordQuestion from "inquirer"' instead?
node-plop:test: ERROR: 11:3   expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'PromptModule'. Did you mean to use 'import PromptModule from "inquirer"' instead?
node-plop:test: ERROR: 13:3   expect  TypeScript@local compile error:
node-plop:test: Module '"inquirer"' has no exported member 'RawListQuestion'. Did you mean to use 'import RawListQuestion from "inquirer"' instead?
node-plop:test: ERROR: 39:35  expect  TypeScript@local compile error:
node-plop:test: Cannot find namespace 'inquirer'.
node-plop:test:

crutchcorn
crutchcorn requested changes Sep 4, 2025
View reviewed changes
Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the code as-expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutchcorn crutchcorn crutchcorn requested changes

+1 more reviewer

@newerton newerton newerton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dev-splin @crutchcorn @newerton